Skip to content

drop --tty on exec#484

Merged
rhatdan merged 1 commit intocontainers:mainfrom
haircommander:drop-tty
Jan 9, 2024
Merged

drop --tty on exec#484
rhatdan merged 1 commit intocontainers:mainfrom
haircommander:drop-tty

Conversation

@haircommander
Copy link
Collaborator

as gvisor doesn't use it, and runc/crun don't need it, as they'll only use it if the process args aren't defined, which conmon always does

fixes #483

as gvisor doesn't use it, and runc/crun don't need it, as they'll only use it if
the process args aren't defined, which conmon always does

Signed-off-by: Peter Hunt <pehunt@redhat.com>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2024

LGTM

@rhatdan rhatdan merged commit 4fcd0c4 into containers:main Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

podman exec -ty causes "Error: OCI runtime error: runsc: flag provided but not defined: -tty" when run with gvisor

3 participants