close_fds: fix close of external fds#241
Merged
haircommander merged 1 commit intocontainers:masterfrom Mar 1, 2021
Merged
Conversation
Member
Author
|
CC @baude |
Collaborator
|
LGTM, @giuseppe did you test against podman unit/system tests? since we don't run them on CI it has to be manually done (for now..) |
Member
Author
I've ran the e2e tests and they pass locally |
src/close_fds.c
Outdated
|
|
||
| for (fd = 3; fd < open_files_max_fd; fd++) { | ||
| for (fd = 3; fd <= open_files_max_fd; fd++) { | ||
| if (open_files_set == NULL || FD_ISSET(fd % FD_SETSIZE, &(open_files_set[fd / FD_SETSIZE]))) |
Collaborator
There was a problem hiding this comment.
sorry, one more quick nit, can we return from this function early if open_files_set == NULL?
Member
Author
There was a problem hiding this comment.
good idea!
Pushed new version
commit 0f092d5 introduced the regression. Closes: containers#240 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commit 0f092d5 introduced the
regression.
Closes: #240
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com