Skip to content

fix: fixup memory usage for cgroup v2#870

Merged
openshift-merge-robot merged 1 commit into
containers:mainfrom
ttys3:cgroupv2-memory-usage
Dec 26, 2021
Merged

fix: fixup memory usage for cgroup v2#870
openshift-merge-robot merged 1 commit into
containers:mainfrom
ttys3:cgroupv2-memory-usage

Conversation

@ttys3

@ttys3 ttys3 commented Dec 25, 2021

Copy link
Copy Markdown

podman stats show the usage memory is wrong.

it shows container memory usage is 12GB while it only uses 1.5GB.

because it contains network traffic.

podman related PR: podman-container-tools/podman#12703

related podman issue: podman-container-tools/podman#12702

@ttys3

ttys3 commented Dec 26, 2021

Copy link
Copy Markdown
Author

/assign @vrothberg

Comment thread pkg/cgroups/memory.go Outdated
@rhatdan

rhatdan commented Dec 26, 2021

Copy link
Copy Markdown
Member

Thanks @ttys3, one NIT, and then LGTM
/approve

@ttys3 ttys3 force-pushed the cgroupv2-memory-usage branch from ff0756f to d894cb2 Compare December 26, 2021 12:30
@rhatdan

rhatdan commented Dec 26, 2021

Copy link
Copy Markdown
Member

LGTM
@containers/podman-maintainers PTAL
@giuseppe PTAL

Comment thread pkg/cgroups/memory.go Outdated
@ttys3 ttys3 force-pushed the cgroupv2-memory-usage branch from d894cb2 to c7fd073 Compare December 26, 2021 13:47
@ttys3 ttys3 requested a review from giuseppe December 26, 2021 14:05

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Dec 26, 2021

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan, ttys3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants