seccomp: accept strings for errno values#821
seccomp: accept strings for errno values#821openshift-merge-robot merged 2 commits intocontainers:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f6c766c to
3d25e23
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
simplify maintainance of the seccomp.json file and accept errno as strings. It also fixes a portability problem since errno values are arch dependent. The existing `DefaultErrnoRet` and `ErrnoRet` are maintained for backward compatibility but they are obsoleted and will be removed in a future release. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
3d25e23 to
a27cbd6
Compare
vrothberg
left a comment
There was a problem hiding this comment.
LGTM
Could you open a test PR against Podman?
|
opened a PR for Podman: containers/podman#12238 |
|
Podman tests are green |
|
@containers/podman-maintainers PTAL |
Thank you! |
|
/lgtm |
|
@giuseppe @vrothberg is this going to cause us update issues, with the seccomp.json file not being understood on older versions of Podman and Buildah? |
|
No, old tools will understand the numeric value, while new ones will use the string. Once it is safe to assume all versions we care about understand the string then we can completely remove the numeric value. |
simplify maintainance of the seccomp.json file and accept errno as
strings.
It also fixes a portability problem since errno values are arch
dependent.
The existing
DefaultErrnoRetandErrnoRetare maintained forbackward compatibility but they are obsoleted and will be removed in a
future release.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com