Vendor c/storage#2131
Merged
openshift-merge-bot[bot] merged 2 commits intocontainers:mainfrom Aug 22, 2024
Merged
Conversation
mtrmac
requested changes
Aug 21, 2024
Contributor
mtrmac
left a comment
There was a problem hiding this comment.
Thanks!
The code changes LGTM.
Contributor
|
(I suspect that the “Fix SA1019…” and “Vendor containerd/platforms” commits should be squashed because the project wouldn’t build with |
Signed-off-by: Jan Rodák <hony.com@seznam.cz>
…orms with github.com/containerd/platforms Signed-off-by: Jan Rodák <hony.com@seznam.cz> Vendor containerd/platforms Signed-off-by: Jan Rodák <hony.com@seznam.cz>
0aeded7 to
24daa5c
Compare
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Honny1, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@Honny1 when you remove [WIP] this should merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendor pre-release version of
c/storage:8ec73cadc730for #2125. It also fixes a linter issue caused by vendoring.