Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containers/common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.60.2
Choose a base ref
...
head repository: containers/common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.60.3
Choose a head ref
  • 6 commits
  • 2 files changed
  • 2 contributors

Commits on Aug 20, 2024

  1. Merge pull request #2127 from TomSweeneyRedHat/dev/tsweeney/v0.60.2

    [v0.60] Bump c/image to v5.32.2, c/common to v0.60.2
    openshift-merge-bot[bot] authored Aug 20, 2024
    Configuration menu
    Copy the full SHA
    52c82b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. pkg/netns: split out makeNetnsDir logic

    Create a new function to create the netns dir.
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    322f2c2 View commit details
    Browse the repository at this point in the history
  2. pkg/netns: ensure makeNetnsDir is race free

    There are some rather bad problems when we bind mount over multiple
    times, this is a rather small race but can happen. In order to avoid
    this take an exclusive lock like ip netns add does because they create
    the same bind mount setup. As such we will not race against other podman
    process or ip netns add which is a good thing.
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    50870e9 View commit details
    Browse the repository at this point in the history
  3. pkg/netns: add NewNSFrom()

    The new API should replace the logic from Podman's setupNetNS() which
    did several things incorrect. First and foremost it never bind mounted
    the netns dir causing problems when the netns dir was later bind mounted
    duplicating the netns mounts on diffeent parents which then caused all
    unmount attempts to fail[1].
    
    Also the Podman code did never check for conlicts so we way end up
    overwriting an existing netns (super unlikely as we use 16 random bytes
    but still). At the very least it duplicates the name logic for no reason
    there so having this all here makes much more sense.
    
    Of course we still have to port podman over to this new API.
    
    [1] https://issues.redhat.com/browse/RHEL-59620
    Backport for https://issues.redhat.com/browse/RHEL-59703
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8a5b951 View commit details
    Browse the repository at this point in the history
  4. pkg/netns: remove NewNSWithName()

    This API is not used anywhere, as such remove it and make the loop in
    NewNS() better as the netns dir parts should not be part of the loop.
    
    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2776f6b View commit details
    Browse the repository at this point in the history
  5. Bump to v0.60.3

    Signed-off-by: Paul Holzinger <pholzing@redhat.com>
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    8264002 View commit details
    Browse the repository at this point in the history
Loading