-
Notifications
You must be signed in to change notification settings - Fork 225
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: containers/common
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.60.2
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: containers/common
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.60.3
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 6 commits
- 2 files changed
- 2 contributors
Commits on Aug 20, 2024
-
Merge pull request #2127 from TomSweeneyRedHat/dev/tsweeney/v0.60.2
[v0.60] Bump c/image to v5.32.2, c/common to v0.60.2
Configuration menu - View commit details
-
Copy full SHA for 52c82b1 - Browse repository at this point
Copy the full SHA 52c82b1View commit details
Commits on Sep 20, 2024
-
pkg/netns: split out makeNetnsDir logic
Create a new function to create the netns dir. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 322f2c2 - Browse repository at this point
Copy the full SHA 322f2c2View commit details -
pkg/netns: ensure makeNetnsDir is race free
There are some rather bad problems when we bind mount over multiple times, this is a rather small race but can happen. In order to avoid this take an exclusive lock like ip netns add does because they create the same bind mount setup. As such we will not race against other podman process or ip netns add which is a good thing. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 50870e9 - Browse repository at this point
Copy the full SHA 50870e9View commit details -
The new API should replace the logic from Podman's setupNetNS() which did several things incorrect. First and foremost it never bind mounted the netns dir causing problems when the netns dir was later bind mounted duplicating the netns mounts on diffeent parents which then caused all unmount attempts to fail[1]. Also the Podman code did never check for conlicts so we way end up overwriting an existing netns (super unlikely as we use 16 random bytes but still). At the very least it duplicates the name logic for no reason there so having this all here makes much more sense. Of course we still have to port podman over to this new API. [1] https://issues.redhat.com/browse/RHEL-59620 Backport for https://issues.redhat.com/browse/RHEL-59703 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 8a5b951 - Browse repository at this point
Copy the full SHA 8a5b951View commit details -
pkg/netns: remove NewNSWithName()
This API is not used anywhere, as such remove it and make the loop in NewNS() better as the netns dir parts should not be part of the loop. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 2776f6b - Browse repository at this point
Copy the full SHA 2776f6bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8264002 - Browse repository at this point
Copy the full SHA 8264002View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v0.60.2...v0.60.3