Revert #5627#5629
Merged
openshift-merge-bot[bot] merged 1 commit intocontainers:mainfrom Jul 16, 2024
Merged
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7170328 to
9b24ce9
Compare
This reverts commit 5940e72. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
9b24ce9 to
b756a3d
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
Member
|
Buildah got vendored into podman today, so there probably isn't a big need for the treadmill to be stable. I was just trying to be proactive. |
Member
Author
|
podman might not need it, but |
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
We just updated from a development version of github.com/containers/image/v5 to a version that was cut from its stable release branch. Podman's development branch already depends on features which are newer than the image library's stable branch, and vendoring our development branch was breaking compilation over there.
How to verify it
containers/podman#13808 should be... well, not happy, but closer to happy.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?