bats tests - parallelize#5552
Conversation
d118eb9 to
4a543fd
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
762e878 to
a195865
Compare
a195865 to
d05bc18
Compare
d05bc18 to
053354d
Compare
4d4e9c9 to
e653a16
Compare
Luap99
left a comment
There was a problem hiding this comment.
I assume once we enabled parallel runs here we can port that over for the bud tests on podman? I like to get the speed up there too.
I haven't looked deeply into the prefetch logic changes but this looks much easier than podman so that is good.
tests/test_runner.sh
Outdated
|
|
||
| # Run the tests. | ||
| execute time bats --tap $TESTS | ||
| execute time bats -j 4 --tap $TESTS |
There was a problem hiding this comment.
I would use $(nproc) here instead of hard coding any count, should make it much faster when run locally.
e653a16 to
31b2ab6
Compare
b01284c to
aed1bc5
Compare
|
A friendly reminder that this PR had no activity for 30 days. |
|
(A brief look after a link from containers/skopeo#2437 )
For this purpose, it would be better to have the image’s layers be clearly independent from any other test — maybe a |
|
… oh, and: debug-level logs could help. |
Thank you. I thought I had checked for conflicts, but must've missed something. I'll look into this again when time allows. |
d17cb1b to
68722ca
Compare
|
Where is that |
|
I can’t see any obvious reason. I’d suggest doing the pushes with |
|
Looks like last few commits fix the flake caused due to parallelize, I am gonna push a few times more. |
058e0e4 to
ebad7b2
Compare
All bats tests run with custom root/runroot, so it should be possible to parallelize them. Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Signed-off-by: Ed Santiago <santiago@redhat.com> Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Address comment here containers#5552 (comment) Signed-off-by: flouthoc <flouthoc.git@gmail.com>
ebad7b2 to
9563e43
Compare
Signed-off-by: flouthoc <flouthoc.git@gmail.com>
Address comment here containers#5552 (comment) Signed-off-by: flouthoc <flouthoc.git@gmail.com>
9563e43 to
c88135a
Compare
Address comment here for cleanup containers#5552 (comment) Signed-off-by: flouthoc <flouthoc.git@gmail.com>
c88135a to
bd2d78e
Compare
|
Okay following PR is ready for review. Flakes which Ed found should are fixed in above commits. I found one more flake but that is unrelated to changes in this PR and exists in upstream ( https://cirrus-ci.com/task/6143954845958144 ) sample PR in upstream #5943 @containers/buildah-maintainers PTAL |
Luap99
left a comment
There was a problem hiding this comment.
Containerized IntegrationSuccessful in 53m
Looks like this does not bump the VM for the Containerized test so that run is still slow.
The in_podman_task in cirrus.yml would need to get the same gce_instance fix like the other integration tasks
LGTM otherwise
@Luap99 Yes I will open a seperate PR for |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: edsantiago, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Created a followup PR: #5947 |
All bats tests run with custom root/runroot, so it should be
possible to parallelize them.
(As of this initial commit, tests fail on my laptop, and I expect them to fail here. I just want to get a sense for how things go.)
Signed-off-by: Ed Santiago santiago@redhat.com