conformance tests: archive the context directory as 0:0#5171
Merged
flouthoc merged 3 commits intocontainers:mainfrom Nov 17, 2023
Merged
conformance tests: archive the context directory as 0:0#5171flouthoc merged 3 commits intocontainers:mainfrom
flouthoc merged 3 commits intocontainers:mainfrom
Conversation
flouthoc
approved these changes
Nov 16, 2023
Collaborator
flouthoc
left a comment
There was a problem hiding this comment.
LGTM
/lgtm
/approve
/hold
fae3e24 to
7a7d3f3
Compare
Collaborator
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7a7d3f3 to
564fc03
Compare
be7eb82 to
4eca335
Compare
Member
|
LGTM |
When uploading a context directory to dockerd, generate the archive ourselves so that we can force the ownerships in it to 0:0, which BuildKit seems to expect clients to do. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
789bec9 to
473a755
Compare
Collaborator
|
/lgtm |
Collaborator
|
Rebased , squashed and merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
When uploading a context directory to dockerd, generate the archive ourselves so that we can force the ownerships in it to 0:0, which BuildKit seems to expect clients to do.
How to verify it
Run those conformance tests!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?