Implement ADD --checksum flag#5152
Conversation
3cb9a6a to
980262a
Compare
flouthoc
left a comment
There was a problem hiding this comment.
PR LGTM other than comments above
|
The overlay unit test is timing out. I don't believe it's related to this change, I suspect it's a flake and will rerun |
|
You need to squash your commits. |
Yep will do. |
Pick up parsing support for ADD --checksum flag. Signed-off-by: Jean-Francois Roy <jf@devklog.net>
See https://docs.docker.com/build/dockerfile/release-notes/#160. Fixes containers#5135 Signed-off-by: Jean-Francois Roy <jf@devklog.net>
I didn't squash the vendor commit since I felt that should be separate, but I'm happy to squash that too. I don't know if you have a policy to keep dependency updates separate. |
|
The vendor is fine to do separately. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, jfroy, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implement the new
ADD --checksumflag. See https://docs.docker.com/build/dockerfile/release-notes/#160.How to verify it
ADD --checksumline.buildah add --checksum ...command.Which issue(s) this PR fixes:
Fixes #5135
Special notes for your reviewer:
Does this PR introduce a user-facing change?