[CI:DOCS] Improve get_ci_vm container docs#362
Merged
cevich merged 1 commit intocontainers:mainfrom Jun 24, 2024
Merged
Conversation
cd41495 to
81ab982
Compare
The readme contained a lot of technical/implementation details, but lacked an overview of the architecture/operations. Fix this. Signed-off-by: Chris Evich <cevich@redhat.com>
edsantiago
approved these changes
Jun 24, 2024
Member
edsantiago
left a comment
There was a problem hiding this comment.
Took me a couple of readings to get it sorted out, but that's because this is tricky. LGTM, thank you.
Luap99
reviewed
Jun 24, 2024
Member
Luap99
left a comment
There was a problem hiding this comment.
LGTM but I haven't actually taken the time to fully understand this.
Member
Author
|
Thanks for taking a read-through guys. Hopefully this is never needed but if it is, exposing the magic could save someone a bunch of time trying to figure it out on their own. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readme contained a lot of technical/implementation details, but lacked an overview of the architecture/operations. Fix this.