libcni: add specific type for CHECK not supported#911
Merged
squeed merged 1 commit intocontainernetworking:mainfrom Sep 19, 2022
Merged
libcni: add specific type for CHECK not supported#911squeed merged 1 commit intocontainernetworking:mainfrom
squeed merged 1 commit intocontainernetworking:mainfrom
Conversation
Previously, we returned an arbitrary string error if the given CNI version didn't support CHECK. This is not useful for downstream consumption and matching. So, declare an error variable so that users can use `errors.Is()` instead of matching on a string. Signed-off-by: Casey Callendrello <c1@caseyc.net>
Member
|
/lgtm |
MikeZappa87
approved these changes
Sep 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we returned an arbitrary string error if the given CNI version didn't support CHECK. This is not useful for downstream consumption and matching.
So, declare an error variable so that users can use
errors.Is()instead of matching on a string.Signed-off-by: Casey Callendrello c1@caseyc.net