spec: allow interfaces to be included in the delegated IPAM plugin result#1121
Open
ruicao93 wants to merge 2 commits intocontainernetworking:mainfrom
Open
spec: allow interfaces to be included in the delegated IPAM plugin result#1121ruicao93 wants to merge 2 commits intocontainernetworking:mainfrom
ruicao93 wants to merge 2 commits intocontainernetworking:mainfrom
Conversation
…sult Signed-off-by: Rui Cao <caorui.io@bytedance.com>
Author
|
hi @squeed, could you please help review the PR? |
LionelJouin
reviewed
Sep 26, 2024
It's a common case that different pods share a same RDMA NIC through macvlan (or ipvlan). For those nodes with multiple RDMA NICs, it's also helpful to use a single IPAM plugin to manage IPs on different devices. |
Author
|
cc @joestringer |
Author
|
@MikeZappa87 More discussions could be found in: cilium/cilium#34779 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the spec specifies the
interfacesarray should not be included in the delegated IPAM plugin result.However, considering a common scenario where there are multiple interfaces on a Node, and each Pod use a dedicated network interface for ingress/egress traffic, the primary CNI plugin needs to know the uplink interface to install the corresponding routes. The muliple interface node is widely used in various clouds:
So we should allow the
interfacesarray be included to hint the uplink interface info(sandboxis emtpy) which can be consumed by the primary CNI plugin.More discussion could be found in: cilium/cilium#34779 (comment)