tolerate invalid cni caches for deletion#1072
Merged
squeed merged 1 commit intocontainernetworking:mainfrom Mar 12, 2024
Merged
tolerate invalid cni caches for deletion#1072squeed merged 1 commit intocontainernetworking:mainfrom
squeed merged 1 commit intocontainernetworking:mainfrom
Conversation
Signed-off-by: Henry Wang <henwang@amazon.com>
This was referenced Mar 7, 2024
Member
Author
squeed
approved these changes
Mar 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1055
Closes: #1066
In
DelNetworkListfunction, ignore the errors returned bygetCachedResultand continue to invoke plugins for deletion as best effort. Also updated the test case to adapt this new behavior.Cached results are deleted from disk in the following two cases:
getCachedResultreturns an error; ORgetCachedResultsucceeds and no errors are returned from pluginsCached results are not deleted if (I think this will allow clients to retry the deletion)
getCachedResultsucceeds AND