Skip to content

ci: update actions, test against go1.23, fix linting, and update golangci-lint #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 8 commits into from
Dec 5, 2025
Merged

ci: update actions, test against go1.23, fix linting, and update golangci-lint #88

AkihiroSuda merged 8 commits into from
Dec 5, 2025

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Dec 5, 2025

No description provided.

@thaJeztah thaJeztah requested a review from AkihiroSuda December 5, 2025 11:56
@thaJeztah
gha: test against go1.23
65bc451 
current v2.0 versions of containerd require go1.23 as minimum, so
update CI to test with that version.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 5, 2025

oh; interesting;

  github.com/vbatts/git-validation
  go: downloading github.com/kunalkushwaha/ltag v0.3.0
  go: github.com/kunalkushwaha/ltag@latest: version constraints conflict:
  	github.com/kunalkushwaha/ltag@v0.3.0: parsing go.mod:
  	module declares its path as: github.com/containerd/ltag
  	        but was required as: github.com/kunalkushwaha/lta

@thaJeztah
gha: update containerd/project-checks@v1.2.2
bb45f6e 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: update actions/setup-go@v6
d23ec04 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: update actions/checkout@v6
c8545c3 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
fix inconsistent receiver name
24ce1b9 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
fix error capitalization
7c4274b 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
remove nolint comments
b0b2584 
There only were a few, and most could be addressed by suppressing the
unhandled errors.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
gha: update golangci/golangci-lint-action@v9, golangci-lint v2.7
662ad3c 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 5, 2025

Ah; updated to containerd/project-checks@v1.2.2

@thaJeztah thaJeztah mentioned this pull request Dec 5, 2025
Merged
@AkihiroSuda AkihiroSuda merged commit 7dad056 into containerd:main Dec 5, 2025
3 checks passed
@thaJeztah thaJeztah deleted the bump_ci branch December 5, 2025 13:49
@thaJeztah
Copy link
Member Author

thaJeztah commented Dec 5, 2025

Thanks @AkihiroSuda - I moved #89 out of draft; perhaps would be good to have a new tag after that, as that one could help with getting rid of some transitive dependencies

@y-ykcir y-ykcir mentioned this pull request Dec 18, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @AkihiroSuda