Add protoc-gen-go-ttrpc #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Google's new protobuf code generator only supports protobuf serialization/deserialization and let other code generators handle RPC-related aspects. This new code generator follows the change and can be used with the new protobuf code generator. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
This was referenced Oct 26, 2021
Codecov Report
@@ Coverage Diff @@
## main #96 +/- ##
==========================================
- Coverage 73.72% 73.58% -0.15%
==========================================
Files 11 11
Lines 708 708
==========================================
- Hits 522 521 -1
- Misses 149 151 +2
+ Partials 37 36 -1
Continue to review full report at Codecov.
|
dmcgowan
approved these changes
Oct 30, 2021
Member
dmcgowan
left a comment
There was a problem hiding this comment.
LGTM
Want to get this in to play around with the streaming additions as well.
This was referenced Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google's new protobuf code generator only supports protobuf
serialization/deserialization and let other code generators handle
RPC-related aspects.
This new code generator follows the change and can be used with
the new protobuf code generator.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com