ttrpc: add a message length check before send#119
Closed
cosmoer wants to merge 1 commit intocontainerd:mainfrom
Closed
ttrpc: add a message length check before send#119cosmoer wants to merge 1 commit intocontainerd:mainfrom
cosmoer wants to merge 1 commit intocontainerd:mainfrom
Conversation
Signed-off-by: Qian Zhang <cosmoer@qq.com>
dmcgowan
reviewed
May 26, 2022
Member
|
Closing, PR #171 merged with implementation for sender-side reject. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In channel.go:recv() function, may be recv a invalid message header，
while the mh.Length value is an unusually large value, a large amount of data will be received and discarded.（But it may not actually send that much data.）
So，ttrpc server will discard all RPC requests, it wasn't what we were hoping for.
Signed-off-by: Qian Zhang cosmoer@qq.com