Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: containerd/ttrpc
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.1
Choose a base ref
...
head repository: containerd/ttrpc
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.2
Choose a head ref
  • 6 commits
  • 4 files changed
  • 5 contributors

Commits on Aug 6, 2020

  1. fix bug, failed to assert net error due to error wrap

    Signed-off-by: blade <blade.shen@ucloud.cn>
    shsjshentao committed Aug 6, 2020
    Configuration menu
    Copy the full SHA
    df11695 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2020

  1. Merge pull request #66 from shsjshentao/fixbug/assertError

    fix bug, failed to assert net error due to error wrap
    stevvooe authored Aug 12, 2020
    Configuration menu
    Copy the full SHA
    09ff6c4 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2020

  1. client: add UserOnCloseWait function

    ttrpc provides WithOnClose option for user and ttrpc will call the
    callback function when connection is closed unexpectedly or the ttrpc
    client's Close() method is called. containerd runtime plugin uses it
    to handle cleanup the resources created by containerd shim.
    
    But the ttrpc client's Close() is only trigger and the shim's cleanup
    resource callback is called asynchronously, which might make part of
    resources leaky. There is an example from containerd-runtime-v2 for
    runc:
    
    ```happy
    [Task.Delete goroutine]         [cleanupCallback goroutine]
    
    call ttrpc client.Close() -->
    
                                      read bundle and call runc delete
    
    delete bundle
    ```
    
    If the cleanupCallback is called after deleting bundle, the callback
    will fail to call runc delete. If there is any running processes, the
    resource becomes leaky.
    
    ```unhappy
    [Task.Delete goroutine]         [cleanupCallback goroutine]
    
    call ttrpc client.Close() -->
    
    delete bundle
    
                                      failed to read bundle and call runc delete
    ```
    
    In order to avoid this, introduces the UserOnCloseWait to make sure that
    the cleanupCallback has been called synchronously, like:
    
    ```
    [Task.Delete goroutine]         [cleanupCallback goroutine]
    
    call ttrpc client.Close() -->
    
    wait for callback
    
                                   read bundle and call runc delete
    
                              <--  finish sync
    
    delete bundle
    ```
    
    Signed-off-by: Wei Fu <fuweid89@gmail.com>
    fuweid committed Sep 7, 2020
    Configuration menu
    Copy the full SHA
    225de2c View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Merge pull request #68 from fuweid/add-user-on-close-wait

    client: add UserOnCloseWait function
    estesp authored Sep 8, 2020
    Configuration menu
    Copy the full SHA
    079556c View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2020

  1. travis: add go 1.15

    Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
    thaJeztah committed Sep 11, 2020
    Configuration menu
    Copy the full SHA
    3e553e9 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge pull request #69 from thaJeztah/test_go_versions

    travis: add go 1.15
    fuweid authored Sep 14, 2020
    Configuration menu
    Copy the full SHA
    bfba540 View commit details
    Browse the repository at this point in the history
Loading