Use Go version associated with containerd release in CI#166
Merged
mxpv merged 1 commit intocontainerd:mainfrom Aug 21, 2023
Merged
Use Go version associated with containerd release in CI#166mxpv merged 1 commit intocontainerd:mainfrom
mxpv merged 1 commit intocontainerd:mainfrom
Conversation
6e1323f to
8e3e30f
Compare
Contributor
Author
|
When looking into this I found that since we need to build the tests from source anyways, we could just use the go version from the source. Got it working but some tests are skipped (go test -test.skip) in CI (#122) using a flag that is only supported in golang 1.20 so CI isn't passing. a couple options to unblock are:
|
Contributor
Author
|
unfortunately CI isn't passing do the skipped tests so will need to fix those or only use golang 1.20+ for the tests |
dbbb381 to
ae67593
Compare
Contributor
Author
4d54042 to
dee6102
Compare
mxpv
reviewed
Aug 21, 2023
|
|
||
| - name: Get Go Version | ||
| run: | | ||
| go_version=$(awk -F': ' '/GO_VERSION/ {gsub(/["'\'']/, "", $2); print $2; exit}' .github/workflows/release.yml) |
Member
There was a problem hiding this comment.
We don't have .github/workflows/release.yml, right?
❯ cat .github/workflows/release.yml
cat: .github/workflows/release.yml: No such file or directory
Contributor
Author
There was a problem hiding this comment.
this is the containerd release file since it is the containerd repository we checked out in the step before
Member
|
Could you also squash the commit history? |
This ensures that there isn't flakes with testing when go version doesn't match the release as experienced in containerd#147 Signed-off-by: James Sturtevant <jstur@microsoft.com>
dee6102 to
2e3b3ef
Compare
mxpv
approved these changes
Aug 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ensures that there isn't failures with testing when go version doesn't match the release as experienced in #147.
this also bumps the containerd versions to latest patches
fixes #147