Skip to content

Update project to latest shim-protos and ttrpc using protobuf 3.x#81

Merged
cpuguy83 merged 1 commit intocontainerd:mainfrom
jsturtevant:protobuf3
Jun 28, 2023
Merged

Update project to latest shim-protos and ttrpc using protobuf 3.x#81
cpuguy83 merged 1 commit intocontainerd:mainfrom
jsturtevant:protobuf3

Conversation

@jsturtevant
Copy link
Copy Markdown
Contributor

In preparation for adding windows #49 which is built using latest ttrpc libraries which use protobuf 3, this PR updates the project to use latest dependencies and moves the protocols to using protobuf 3.

note: There isn't a release of the shim-protos project with these changes yet so it pins a rev. I am going to open an issue on https://github.com/containerd/rust-extensions/ to see if we can get a release (or maybe wait till the windows changes propagate up). Opened this up to show required changes which allow for using Windows.

@jsturtevant
Copy link
Copy Markdown
Contributor Author

This is taking much longer than anticipated, things are moving along but slowly. I am finding it difficult to maintain this patch and work on the Windows implementation with the various changes going in for the youki work.

Any thoughts on pinning to a rev vs a realse so we can start bumping the other dependencies and moving forward on protobuf 3?

@devigned
Copy link
Copy Markdown
Contributor

This is taking much longer than anticipated, things are moving along but slowly. I am finding it difficult to maintain this patch and work on the Windows implementation with the various changes going in for the youki work.

Any thoughts on pinning to a rev vs a realse so we can start bumping the other dependencies and moving forward on protobuf 3?

I'm good with pinning to a rev as long as we have an issue to track the follow up work. What do others think?

Signed-off-by: James Sturtevant <jstur@microsoft.com>
@jsturtevant jsturtevant marked this pull request as ready for review June 27, 2023 23:33
@jsturtevant
Copy link
Copy Markdown
Contributor Author

@jsturtevant
Copy link
Copy Markdown
Contributor Author

I'm good with pinning to a rev as long as we have an issue to track the follow up work. What do others think?

I've refreshed the PR and opened #162 to track updating getting this on a release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants