Build test image without docker.#41
Merged
cpuguy83 merged 1 commit intocontainerd:mainfrom Jan 3, 2023
Merged
Conversation
Member
Author
|
@jsturtevant for testing on Windows. |
86830e9 to
30455b5
Compare
rumpl
reviewed
Dec 19, 2022
Contributor
the sample program and image file build run on windows. When I tried loading it into containerd I got the follow error: I don't think this is an issue with this PR per say. I am sort of guessing but might be related to the fact that Windows doesn't have a "baselayer" or doesn't know how handle the image layer produced. I'll have to dig in deeper to figure it out. I don't think we should hold this up for Windows support as there is quite a bit work to do there anyways. |
cd14260 to
914bb41
Compare
This manually assembles the tar instead of requring buildkit/buildx/docker to create it. Instead of using buildx to stick our single binary into a container image we can build the tar ourself. This should work on Windows (not tested...) or Linux and only depends on cargo to build. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
914bb41 to
deb8a4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This manually assembles the tar instead of requring buildkit/buildx/docker to create it.
Instead of using buildx to stick our single binary into a container image we can build the tar ourself.
This should work on Windows (not tested...) or Linux and only depends on cargo to build.
Closes #36