Fix issue running k8s and cross locally#362
Conversation
jprendes
left a comment
There was a problem hiding this comment.
I don't think we need a wrapper script.
We are already specifying the target in the Makefile with TARGET_FLAG.
It's just a matter of adding --target-dir=./target/build/$(TARGET) to TARGET_FLAG.
You also need to use the same target-dir in the install-% rule (IIUC, that's why CI failed).
I propose we use a new makefile variable TARGET_DIR, and we set it to ./target/build/$(TARGET) when using cross or to ./target otherwise.
|
looks like latest failures is due to cross setting. This is working locally when I run it, with same setting 👀 |
125da87 to
e2cd07a
Compare
Mossaka
left a comment
There was a problem hiding this comment.
lgtm! I didn't run the commands locally though. Will try it out next week.
Signed-off-by: James Sturtevant <jstur@microsoft.com> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com> Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
c78c864 to
99c3951
Compare
|
I am trying to get |
|
Merging it in now. The progress on my side is slow and I don't want to block the PR |
This PR addresses two issues after #359 when running
make test/k8s-wasmtimelocally.First, the
TARGETis not being set properly. SinceTARGETwas already set when re-invoking$(MAKE)it gets the prior value. Example output:Second, cross has issues when switching targets: https://github.com/cross-rs/cross/wiki/FAQ#glibc-version-error. I ran into this only my local set up, where the first step of cross (after fixing the above) would error out with
This also adds a
cleantarget which allows for testing this scenario, otherwise several of the steps get skipped since they already compiled.