Bump libcontainer to include UB fix#354
Merged
Mossaka merged 3 commits intocontainerd:mainfrom Oct 17, 2023
Merged
Conversation
Contributor
|
great work on this issue! Should we split out #347 (comment) into it's own issue? |
Collaborator
Author
Opened #357 |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Collaborator
Author
|
youki-dev/youki#2425 has now been merged. |
utam0k
reviewed
Oct 15, 2023
Co-authored-by: Toru Komatsu <k0ma@utam0k.jp> Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Member
|
Also we can remove the comment. |
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
utam0k
approved these changes
Oct 15, 2023
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #347 (at least the CI failures, not the follow up issue discussed in #347 (comment) and on slack)