Merged
Conversation
64c75ee to
5f0947f
Compare
Collaborator
Author
|
We've used this to build the x86_64 and aarch64 binaries we ship with Docker Desktop. |
cpuguy83
approved these changes
Sep 28, 2023
jsturtevant
reviewed
Sep 28, 2023
Signed-off-by: Jorge Prendes <jorge.prendes@gmail.com>
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the use of
cross-rsfor building and testing.It also works as an example on how to set up the cross containers for building
runwasiwithlibseccompThis PR depends on #331 as otherwise wasmedge wouldn't build on
musltargets.Note that the release workflows are not using
cross-rswhich can be done in a follow up PR.