Use "go mod" instead of vndr when GO111MODULE is "on"#26
Closed
kzys wants to merge 1 commit intocontainerd:masterfrom
Closed
Use "go mod" instead of vndr when GO111MODULE is "on"#26kzys wants to merge 1 commit intocontainerd:masterfrom
kzys wants to merge 1 commit intocontainerd:masterfrom
Conversation
As Derek suggested at containerd/containerd#3182, this change adds Go modules support for the script first. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Member
Author
Merged
Contributor
|
See discussion on #25 for why I don't think checking this environment variable is a good idea. |
Member
|
Trying approach from #25 If that is not sufficient then we can try using the env. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As Derek suggested at
containerd/containerd#3182,
this change adds Go modules support for the script first.
Signed-off-by: Kazuyoshi Kato katokazu@amazon.com