Skip to content

Add fuweid and Ace-Tang as reviewers#13

Merged
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:add-fuweid-ace-tag
Nov 29, 2018
Merged

Add fuweid and Ace-Tang as reviewers#13
dmcgowan merged 1 commit intocontainerd:masterfrom
dmcgowan:add-fuweid-ace-tag

Conversation

@dmcgowan
Copy link
Member

Wei Fu and Ace Tang have been making valuable contributions by fixing issues, adding valuable features, and helping to review code. Their commitment to the quality of the project makes them great candidates to be reviewers.

Wei Fu and Ace Tang have been making valuable contributions
by fixing issues, adding valuable features, and helping
to review code. Their commitment to the quality of the
project makes them great candidates to be reviewers.

Signed-off-by: Derek McGowan <derek@mcgstyle.net>
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge LGTM! Their contributions and help have been amazing to the project!

@crosbymichael
Copy link
Member

LGTM

Copy link

@lowenna lowenna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan
Copy link
Member Author

LGTM, we hit the 1/3 maintainer threshold

@fuweid and @Ace-Tang can you LGTM this as well and we can get it merged

@fuweid
Copy link
Member

fuweid commented Nov 29, 2018

LGTM

1 similar comment
@Ace-Tang
Copy link

LGTM

@dmcgowan dmcgowan merged commit df911b5 into containerd:master Nov 29, 2018
@fuweid
Copy link
Member

fuweid commented Nov 29, 2018

Thank you all!

Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the party, LGTM ㊗️

@Ace-Tang
Copy link

Very honored to become reviewer ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants