(testing): go.mod: downgrade ttrpc to latest v1.1.x release#70
Closed
thaJeztah wants to merge 3 commits intocontainerd:mainfrom
Closed
(testing): go.mod: downgrade ttrpc to latest v1.1.x release#70thaJeztah wants to merge 3 commits intocontainerd:mainfrom
thaJeztah wants to merge 3 commits intocontainerd:mainfrom
Conversation
Member
Author
|
just testing if this would work 😅 |
7509d79 to
af321f5
Compare
Member
Author
|
Looks like we need v1.2.0 as a minimum (containerd/ttrpc@d28bc92 is v1.2.0 and up); |
Member
Author
|
And I see v1.2.3 was tagged; https://github.com/containerd/ttrpc/releases/tag/v1.2.3 |
af321f5 to
d91a17a
Compare
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
d91a17a to
a38edc6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 64.44% 64.55% +0.10%
==========================================
Files 10 10
Lines 1845 1845
==========================================
+ Hits 1189 1191 +2
+ Misses 505 503 -2
Partials 151 151 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
downgrade the minimum required version to v1.1.1. consumers
of this module can pick higher versions to match their
requirements.