-
Notifications
You must be signed in to change notification settings - Fork 731
update gomodjail (0.1.3), Go (1.25), ... #4490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
|
Lint failures are annoying Details
https://github.com/containerd/nerdctl/actions/runs/17294879972/job/49090536229?pr=4490 Details
https://github.com/containerd/nerdctl/actions/runs/17294879986/job/49090535739?pr=4490 |
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Some rules are disabled to silence the errors introduced in this release of golangci-lint. See PR 4490 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
I think it may be caused by the new version golangci-lint. The new golangci-lint is detecting these shadowing violations that weren't caught before. |
| - name: redundant-test-main-exit | ||
| disabled: true | ||
| - name: enforce-switch-style | ||
| disabled: true | ||
| - name: var-naming | ||
| disabled: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we should refactor test code to enable these checks in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can create an issue to track the refactor work.
ChengyuZhu6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.