Skip to content

CI: move FreeBSD and Windows tests to GHA#2418

Merged
AkihiroSuda merged 3 commits intocontainerd:mainfrom
AkihiroSuda:ci-windows-gha
Aug 6, 2023
Merged

CI: move FreeBSD and Windows tests to GHA#2418
AkihiroSuda merged 3 commits intocontainerd:mainfrom
AkihiroSuda:ci-windows-gha

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda commented Aug 5, 2023 •
edited
Loading

Fix #2412

@AkihiroSuda AkihiroSuda added area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2) labels Aug 5, 2023
@AkihiroSuda AkihiroSuda added this to the v1.5.1 (tentative) milestone Aug 5, 2023
@AkihiroSuda AkihiroSuda force-pushed the ci-windows-gha branch 3 times, most recently from 6c72254 to 015280d Compare August 5, 2023 12:29
@AkihiroSuda AkihiroSuda marked this pull request as draft August 5, 2023 12:39
@AkihiroSuda AkihiroSuda force-pushed the ci-windows-gha branch 16 times, most recently from 0cbcf0c to c6ab2ca Compare August 5, 2023 16:22
@AkihiroSuda AkihiroSuda requested a review from jsturtevant August 5, 2023 16:39
@AkihiroSuda
Copy link
Copy Markdown
Member Author

AkihiroSuda commented Aug 5, 2023

cc @gabriel-samfira @aznashwan FYI

The CI is now green for Windows

@AkihiroSuda AkihiroSuda mentioned this pull request Aug 5, 2023
Closed
@AkihiroSuda AkihiroSuda changed the title CI: move Windows tests to GHA CI: move FreeBSD and Windows tests to GHA Aug 5, 2023
@AkihiroSuda
test-integration-docker-compatibility: install Docker 20.10
65934e9 
The test suite is still not ready for Docker 23 (issue 2421)

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
CI: move FreeBSD tests to GHA
855da42 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
CI: move Windows tests to GHA
2888c38 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda marked this pull request as ready for review August 5, 2023 17:22
@AkihiroSuda AkihiroSuda requested a review from fuweid August 6, 2023 12:53
fuweid
fuweid approved these changes Aug 6, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Vagrantfile.freebsd
config.vm.box = "generic/freebsd13"

memory = 2048
cpus = 1
Copy link
Copy Markdown
Member

@fuweid fuweid Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need two cpus here?

Copy link
Copy Markdown
Member Author

@AkihiroSuda AkihiroSuda Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

Copy link
Copy Markdown
Member

@fuweid fuweid Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I see the original one (.cirrus.yml) was using two cpus 😂

@AkihiroSuda AkihiroSuda merged commit 7b7522e into containerd:main Aug 6, 2023
@aznashwan aznashwan mentioned this pull request Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuweid fuweid fuweid approved these changes

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees

No one assigned

Labels

area/ci e.g., CI failure platform/FreeBSD FreeBSD platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2)

Projects

None yet

Milestone

v1.6.0

Development

Successfully merging this pull request may close these issues.

[Windows] TestStart is failing (hcs::CreateComputeSystem ... The requested operation for attach namespace failed)

2 participants

@AkihiroSuda @fuweid