Move to go modules#7
Conversation
|
@chenrui333 thanks for the PR! Looks good but CI is failing. I believe may be because of this line: https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L26 It looks like go get behavior is a bit different in 1.13. We can update this to just manually git clone and build
https://github.com/containerd/imgcrypt/blob/master/script/setup/install-runc#L24 Which needs to be updated to parse go mod instead of vendor.conf. |
|
@lumjjb I will spend some time tomorrow on this, too busy today. :) |
|
Awesome! No worries. Thanks! :D |
|
FYI, I will spend more time on this later today or tomorrow. :) |
|
@chenrui333 Happy New Year! How are things going? |
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
Signed-off-by: Rui Chen <chenrui333@gmail.com>
|
@lumjjb Happy new year!! |
Signed-off-by: Rui Chen <chenrui333@gmail.com>
lumjjb
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the contribution!
Issue tracker, containerd/containerd#3031