github.com/sirupsen/logrus -> github.com/Sirupsen/logrus#5
Closed
AkihiroSuda wants to merge 1 commit intocontainerd:masterfrom
Closed
github.com/sirupsen/logrus -> github.com/Sirupsen/logrus#5AkihiroSuda wants to merge 1 commit intocontainerd:masterfrom
AkihiroSuda wants to merge 1 commit intocontainerd:masterfrom
Conversation
For ease of vendoring go-runc in containerd. (It had required both sirupsen/logrus and Sirupsen/logrus) Signed-off-by: Akihiro Suda <suda.akihiro@lab.ntt.co.jp>
Member
|
@AkihiroSuda thanks. I actually pushed a commit returning the error and removing logrus so we don't have to worry about this anymore for the package. I think its better overall for the package and solves this problem as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ease of vendoring go-runc in containerd.
(It had required both sirupsen/logrus and Sirupsen/logrus)
https://github.com/docker/containerd/pull/415/files#r95741905
Signed-off-by: Akihiro Suda suda.akihiro@lab.ntt.co.jp