Reorder pipe close to be write/read#46
Merged
estesp merged 1 commit intocontainerd:masterfrom Aug 23, 2018
jterry75:fix_pipe_close
Merged
Reorder pipe close to be write/read#46estesp merged 1 commit intocontainerd:masterfrom jterry75:fix_pipe_close
estesp merged 1 commit intocontainerd:masterfrom
jterry75:fix_pipe_close
Conversation
Reorder's pipe close to avoid locking issues. By closing write then read if there is an outstanding relay that could be holding a lock the write end of the pipe forwards the EOF close to the read side freeing any relay's. Signed-off-by: Justin Terry (VM) <juterry@microsoft.com>
Contributor
Author
|
@crosbymichael - FYI. Will need to vendor this into containerd after merge here. |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder's pipe close to avoid locking issues. By closing write then read
if there is an outstanding relay that could be holding a lock the write
end of the pipe forwards the EOF close to the read side freeing any
relay's.
Signed-off-by: Justin Terry (VM) juterry@microsoft.com