Skip to content

Use Go modules instead of vndr#50

Merged
estesp merged 3 commits intocontainerd:masterfrom
kzys:go-mod
Nov 21, 2019
Merged

Use Go modules instead of vndr#50
estesp merged 3 commits intocontainerd:masterfrom
kzys:go-mod

Conversation

@kzys
Copy link
Copy Markdown
Member

@kzys kzys commented Nov 21, 2019

Based on containerd/project#25 and to someday support containerd/containerd#3182, this change moves go-cni from vndr to Go modules.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Kazuyoshi Kato added 2 commits November 21, 2019 12:59
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@codecov-io
Copy link
Copy Markdown

codecov-io commented Nov 21, 2019

Codecov Report

Merging #50 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   42.29%   42.29%           
=======================================
  Files           8        8           
  Lines         357      357           
=======================================
  Hits          151      151           
  Misses        176      176           
  Partials       30       30

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d20b7ee...7332d8a. Read the comment docs.

Copy link
Copy Markdown
Member

@mxpv mxpv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit 60d1252 into containerd:master Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants