Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

[release/1.4] sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e#1639

Merged
fuweid merged 2 commits intorelease/1.4from
update-pull-cri-containerd-node-e2e
May 14, 2021
Merged

[release/1.4] sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e#1639
fuweid merged 2 commits intorelease/1.4from
update-pull-cri-containerd-node-e2e

Conversation

@mikebrow
Copy link
Copy Markdown
Member

@mikebrow mikebrow commented May 13, 2021

  • go mod off (we upgraded golang a while back but don't have go modules here so...)
  • sync containerd vendor
  • fixed pull-cri-containerd-node-e2e

Signed-off-by: Mike Brown brownwm@us.ibm.com

Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow changed the title fixes for pull-cri-containerd-node-e2e [wip] fixes for pull-cri-containerd-node-e2e May 13, 2021
@mikebrow mikebrow changed the title [wip] fixes for pull-cri-containerd-node-e2e [wip] sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e May 13, 2021
@mikebrow mikebrow force-pushed the update-pull-cri-containerd-node-e2e branch 3 times, most recently from 4de742a to 1cafdbe Compare May 13, 2021 22:46
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
@mikebrow mikebrow force-pushed the update-pull-cri-containerd-node-e2e branch from 1cafdbe to f6d33ae Compare May 13, 2021 23:47
@mikebrow mikebrow changed the title [wip] sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e May 14, 2021
@fuweid fuweid changed the title sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e [release/1.4] sync vendor with containerd 1.4 latest; fixes for pull-cri-containerd-node-e2e May 14, 2021
Copy link
Copy Markdown
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Run ../project/script/validate/vendor
2021/05/13 23:48:17 Collecting initial packages
2021/05/13 23:48:17 Download dependencies
2021/05/13 23:48:19 Starting whole vndr cycle because no package specified
2021/05/13 23:49:08 Dependencies downloaded. Download time: 49.151608305s
2021/05/13 23:49:08 Collecting all dependencies
2021/05/13 23:49:12 Clean vendor dir from unused packages
2021/05/13 23:49:13 Success
2021/05/13 23:49:13 Running time: 55.760979661s
vendor/ go.mod go.sum is correct

The vendor checker works well.

@fuweid fuweid merged commit c3073a3 into release/1.4 May 14, 2021
@fuweid fuweid deleted the update-pull-cri-containerd-node-e2e branch May 14, 2021 04:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants