Hi @dims. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

/ok-to-test

@mikebrow yep. thinking aloud here by filing this WIP.

• When we brought up moving the streaming package to a new repo (or staging), the desire popped up that this functionality should be part of CRI itself and hence it stalled.
• The last i saw some progress was a while ago - [CRI] Add authentication to streaming server kubernetes/kubernetes#36666 (comment)
• the last KEP/discussion about desire was here - KEP proposing to move streaming library to a new home kubernetes/enhancements#937 (comment)

So the thought here is may be we should just create a repo here in containerd for things we need here to cut the cord to k8s.io/kubernetes. We may be able to convince folks in k/k to use that repo and drop the code from k/k.

@mikebrow we may be able to get away with a separate go.mod file for integration, but that would not work well with vndr ( i haven't tried yet ). but we can't get away from doing something about streaming for sure.

cc @tallclair @Random-Liu @derekwaynecarr @dchen1107

The copyright headers must be kept

if we go this way ... since it's an abrupt copy... we can paste our new headers above the old ones.

@mikebrow yep. thinking aloud here by filing this WIP.

• When we brought up moving the streaming package to a new repo (or staging), the desire popped up that this functionality should be part of CRI itself and hence it stalled.
• The last i saw some progress was a while ago - kubernetes/kubernetes#36666 (comment)
• the last KEP/discussion about desire was here - kubernetes/enhancements#937 (comment)

So the thought here is may be we should just create a repo here in containerd for things we need here to cut the cord to k8s.io/kubernetes. We may be able to convince folks in k/k to use that repo and drop the code from k/k.

That makes sense.. Thanks. Nice to have a wip PR even if only just for testing the process and getting closer to go mod while waiting for the k8s decision. Natives are getting very restless on this whole go mod thing. Personally I'm fine with vndr but I realize we are holding others up.

@mikebrow we may be able to get away with a separate go.mod file for integration, but that would not work well with vndr ( i haven't tried yet ). but we can't get away from doing something about streaming for sure.

true we can do a /tmp for integration..

@mikebrow going to see if i can push for something in k/k - please chime in on kubernetes/kubernetes#90552

@dims can we just split this up into multiples PRs... e.g. one for the integration/ dependencies on k8s namely kubelet/remote and kubelet/util.....

Then we can tackle server/streaming hopefully by importing it from a common repo..
There's also pkg/util/bandwidth..

Ack @mikebrow will do soon hopefully in a few days

/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-node-e2e

/test pull-cri-containerd-node-e2e

Added notes on how to copy stuff next time.

Added notes on how to do this next time :)

Some stats on what we pulled in:

[dims@dims-a01 08:31] ~/go/src/github.com/containerd/cri ⟩ gocloc integration/remote
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Go                               7            248            259            790
-------------------------------------------------------------------------------
TOTAL                            7            248            259            790
-------------------------------------------------------------------------------
[dims@dims-a01 08:31] ~/go/src/github.com/containerd/cri ⟩ gocloc pkg/streaming
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Go                              12            293            494           1298
-------------------------------------------------------------------------------
TOTAL                           12            293            494           1298
-------------------------------------------------------------------------------
[dims@dims-a01 08:31] ~/go/src/github.com/containerd/cri ⟩ gocloc integration/util
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Go                               7            122            207            271
-------------------------------------------------------------------------------
TOTAL                            7            122            207            271
-------------------------------------------------------------------------------
[dims@dims-a01 08:31] ~/go/src/github.com/containerd/cri ⟩ gocloc pkg/server/bandwidth
-------------------------------------------------------------------------------
Language                     files          blank        comment           code
-------------------------------------------------------------------------------
Go                               6            102            194            378
-------------------------------------------------------------------------------
TOTAL                            6            102            194            378
-------------------------------------------------------------------------------

Is there going to be a follow up change here to reduce the scope of these moved libraries?

@dmcgowan yes will poke at it as time permits.