Skip to content
This repository was archived by the owner on Mar 9, 2022. It is now read-only.

Fix privileged support#1356

Merged
Random-Liu merged 2 commits intocontainerd:masterfrom
Random-Liu:revert-#1349
Dec 12, 2019
Merged

Fix privileged support#1356
Random-Liu merged 2 commits intocontainerd:masterfrom
Random-Liu:revert-#1349

Conversation

@Random-Liu
Copy link
Copy Markdown
Member

@Random-Liu Random-Liu commented Dec 10, 2019

Fix privileged support.

Signed-off-by: Lantao Liu lantaol@google.com

@Random-Liu Random-Liu changed the title Revert "Use containerD WithHostDevices" Fix privileged support Dec 10, 2019
Signed-off-by: Lantao Liu <lantaol@google.com>
@mikebrow
Copy link
Copy Markdown
Member

#1349 (comment)

@mikebrow
Copy link
Copy Markdown
Member

mikebrow commented Dec 10, 2019

Build execution time has reached the maximum allowed time for your plan (60 minutes).

hmm

Signed-off-by: Lantao Liu <lantaol@google.com>
@Random-Liu
Copy link
Copy Markdown
Member Author

This seems to be a appveyor issue. Containerd test is fine. Not sure whether it is golang version related. Try to update to 1.13.4 to be the same with containerd.

@mikebrow
Copy link
Copy Markdown
Member

This seems to be a appveyor issue. Containerd test is fine. Not sure whether it is golang version related. Try to update to 1.13.4 to be the same with containerd.

time to move up anyway

@mikebrow mikebrow mentioned this pull request Dec 11, 2019
Copy link
Copy Markdown
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Random-Liu Random-Liu merged commit e68cc95 into containerd:master Dec 12, 2019
@Random-Liu Random-Liu deleted the revert-#1349 branch December 12, 2019 01:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants