switch to github.com/containerd/log module#243
Merged
Conversation
Member
|
Please rebase to pass the CI |
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
1651a36 to
7d07d28
Compare
dmcgowan
approved these changes
Oct 25, 2024
AkihiroSuda
reviewed
Oct 26, 2024
| require github.com/stretchr/testify v1.3.0 // indirect | ||
| require ( | ||
| github.com/sirupsen/logrus v1.9.3 // indirect | ||
| gopkg.in/yaml.v3 v3.0.1 // indirect |
Member
There was a problem hiding this comment.
containerd/log doesn't seem to depend on yaml 🤔
Member
Author
There was a problem hiding this comment.
Yeah, it's through testify;
go mod graph | grep ' gopkg.in/yaml.v3'
github.com/containerd/continuity gopkg.in/yaml.v3@v3.0.1
github.com/stretchr/testify@v1.7.0 gopkg.in/yaml.v3@v3.0.0-20200313102051-9f266ea9e77cWhich is depended on through logrus;
go mod graph | grep ' github.com/stretchr/testify@v1.7.0'
github.com/sirupsen/logrus@v1.9.3 github.com/stretchr/testify@v1.7.0
Member
Author
There was a problem hiding this comment.
Ah! I think I know what happened; it can be removed indeed. The v3.0.0-20200313102051-9f266ea9e77c -> v3.0.1 may have been either a manual bump (to prevent an old version with CVEs), or possibly stuck after it was updated indirectly. Go mod doesn't remove such lines automatically, but it doesn't add them back if you remove them manually; it's worth sometimes removing all the // indirect dependencies, and see if there's ones that are actually gone.
let me open a PR to get rid of it.
AkihiroSuda
approved these changes
Oct 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.