fs: use io.Copy because go supports CopyFileRange#227
Merged
Conversation
Member
|
I wonder if we could just get rid of this function all together, for unix we still do Based on the Go code though, this buffer will never be used for os.File to os.File copying though |
a747c08 to
577e360
Compare
Member
Author
Updated. Please take a look. |
0be4dfb to
80e9692
Compare
dmcgowan
reviewed
Jun 11, 2023
| tgtWriter = onlyWriter{tgt} | ||
| } | ||
|
|
||
| buf := bufferPool.Get().(*[]byte) |
Member
There was a problem hiding this comment.
The buffer didn't even end up getting used before, should we even bother with it rather than checking OS. It could be possible for Go to implement copy optimizations on other platforms as well.
Member
Author
There was a problem hiding this comment.
Updated. Let's use io.Copy directly.
REF: golang/go@7be3f09 Signed-off-by: Wei Fu <fuweid89@gmail.com>
80e9692 to
4b8bec5
Compare
kzys
approved these changes
Jun 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REF: golang/go@7be3f09