Enable tests for all platforms#220
Merged
Merged
Conversation
95e1039 to
fd0d355
Compare
Signed-off-by: Derek McGowan <derek@mcg.dev>
fd0d355 to
41738e0
Compare
samuelkarp
reviewed
Apr 20, 2023
samuelkarp
left a comment
Member
There was a problem hiding this comment.
I've been meaning to do FreeBSD tests for this too on Cirrus, though that can be a separate PR.
| func copyXAttrs(dst, src string, excludes map[string]struct{}, errorHandler XAttrErrorHandler) error { | ||
| xattrKeys, err := sysx.LListxattr(src) | ||
| if err != nil { | ||
| if os.IsPermission(err) { |
Member
There was a problem hiding this comment.
Suggested change
| if os.IsPermission(err) { | |
| if os.IsPermission(err) && runtime.GOOS == "darwin" { |
?
Member
|
It'd also be good to test more filesystems: #172 |
Signed-off-by: Derek McGowan <derek@mcg.dev>
Signed-off-by: Derek McGowan <derek@mcg.dev>
41738e0 to
b449cd0
Compare
Member
Author
|
@samuelkarp agreed, would be a little bit more involved. I'm not completely sure about the Windows test, at least what has changed, we should at least have the tests pass for our CI environment. Expanding to more environments would be good though given how the fs library is used. |
samuelkarp
approved these changes
Apr 21, 2023
Member
|
I opened #221 to track adding coverage for more filesystems. |
estesp
approved these changes
Apr 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to run tests on more platforms