-
Notifications
You must be signed in to change notification settings - Fork 68
Add more Windows metadata files #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more Windows metadata files #219
Conversation
This adds the hive deltas that get created in WcSandboxState Signed-off-by: Gabriel Adrian Samfira <gsamfira@cloudbasesolutions.com>
kzys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
What would be the authoritative source? MSDN?
Empirical observation, sadly. These are overlay registry hives that get created once a layer is committed with the changes that happened in that particular layer. But there is no publicly available documentation for this, or at least none that I could find. |
|
Perhaps if we ignored the entire The registry hive list in |
It's used here: https://github.com/containerd/continuity/blob/main/fs/fstest/continuity_util.go#L49-L53 If missing or explicitly set to false,
Being able to recursively ignore a folder would be great, but I think that should be part of a different PR. It may be useful on both Windows and Linux, in the future. |
|
Going to go ahead and merge this for now; if there are future improvements to managing the metadata list we can handle with a follow-up PR. |
It seems we missed a few metadata files last time. This adds the hive deltas that get created in WcSandboxState.
Hopefully I got them all this time.