Skip to content

Update GitHub Actions runner images#216

Merged
estesp merged 1 commit into
containerd:mainfrom
austinvazquez:update-github-actions-images
Feb 27, 2023
Merged

Update GitHub Actions runner images#216
estesp merged 1 commit into
containerd:mainfrom
austinvazquez:update-github-actions-images

Conversation

@austinvazquez

@austinvazquez austinvazquez commented Feb 24, 2023

Copy link
Copy Markdown
Member

Resolves deprecation warnings in CI by moving macOS from 10.15 to 12.

Signed-off-by: Austin Vazquez macedonv@amazon.com

@estesp

estesp commented Feb 27, 2023

Copy link
Copy Markdown
Member

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

@kevpar

kevpar commented Feb 27, 2023

Copy link
Copy Markdown
Member

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

I'd recommend we keep both windows-2019 and windows-2022 for the time being. There are a lot of container users still on 2019.

@austinvazquez

austinvazquez commented Feb 27, 2023

Copy link
Copy Markdown
Member Author

Does anyone from the Windows side have an opinion on whether it's better to test both windows-2019 and windows-2022 or OK to move to windows-2022 only? @kevpar?

I'd recommend we keep both windows-2019 and windows-2022 for the time being. There are a lot of container users still on 2019.

Sounds good. Thanks @kevpar. Will revert and add the new Windows runner to the testing matrix.

@austinvazquez
Update GitHub Actions runner images
ad9c903 
Resolves deprecation warnings in CI by moving macOS from 10.15 to 12.
Adds windows-2022 to testing matrix.

Signed-off-by: Austin Vazquez <macedonv@amazon.com>
@austinvazquez austinvazquez force-pushed the update-github-actions-images branch from 25fe169 to ad9c903 Compare February 27, 2023 18:44
@estesp estesp merged commit d6500b3 into containerd:main Feb 27, 2023
@austinvazquez austinvazquez deleted the update-github-actions-images branch February 28, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@austinvazquez @estesp @kevpar @samuelkarp