Skip to content

fs.CopyDir: support sockets and pipes #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmcgowan merged 1 commit into from
Mar 30, 2022
Merged

fs.CopyDir: support sockets and pipes #197

dmcgowan merged 1 commit into from
Mar 30, 2022

Conversation

@AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Mar 30, 2022

No description provided.

@AkihiroSuda AkihiroSuda requested a review from tonistiigi March 30, 2022 08:21
This was referenced Mar 30, 2022
Merged
Merged
@AkihiroSuda AkihiroSuda marked this pull request as draft March 30, 2022 08:38
@AkihiroSuda AkihiroSuda force-pushed the followup-196 branch 2 times, most recently from ba76668 to 3310fe3 Compare March 30, 2022 08:49
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 30, 2022

Why is CI failing?

# github.com/containerd/continuity/fs [github.com/containerd/continuity/fs.test]
Error: fs/copy_unix_test.go:102:13: undefined: os.WriteFile
Error: fs/copy_unix_test.go:120:19: undefined: os.ReadDir
Error: fs/copy_unix_test.go:139:15: undefined: os.ReadFile
FAIL	github.com/containerd/continuity/fs [build failed]

These functions should have been available since Go 1.16

@AkihiroSuda AkihiroSuda force-pushed the followup-196 branch 5 times, most recently from 86435ac to b33bc87 Compare March 30, 2022 09:52
@AkihiroSuda AkihiroSuda marked this pull request as ready for review March 30, 2022 09:52
@AkihiroSuda AkihiroSuda mentioned this pull request Mar 30, 2022
Merged
@AkihiroSuda
fs.CopyDir: support sockets and pipes
ca52b93 
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
estesp
estesp approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmcgowan dmcgowan merged commit d132b28 into containerd:main Mar 30, 2022
@AkihiroSuda
Copy link
Member Author

AkihiroSuda commented Mar 31, 2022

@tonistiigi LGTY?

@xinfengliu xinfengliu mentioned this pull request May 30, 2022
Closed
@dmcgowan dmcgowan mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkihiroSuda @dmcgowan @estesp