Skip to content

Build containerd/continuity on multiple Unix OSes#190

Merged
estesp merged 1 commit into
containerd:mainfrom
kzys:netbsd
Dec 17, 2021
Merged

Build containerd/continuity on multiple Unix OSes#190
estesp merged 1 commit into
containerd:mainfrom
kzys:netbsd

Conversation

@kzys

@kzys kzys commented Dec 3, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

While the .go files have multiple build tags, they haven't been tested on
GitHub Actions except for FreeBSD.

This change also fixes #183.

Signed-off-by: Kazuyoshi Kato katokazu@amazon.com

@kzys kzys force-pushed the netbsd branch 3 times, most recently from a9dc5a3 to cb048fa Compare December 3, 2021 20:05
@kzys kzys marked this pull request as draft December 3, 2021 20:06
@kzys kzys force-pushed the netbsd branch 4 times, most recently from 170de5a to fbb2850 Compare December 3, 2021 20:19
@kzys kzys changed the title Make this project buildable on NetBSD Build containerd/continuity on multiple Unix OSes Dec 3, 2021
@kzys kzys force-pushed the netbsd branch 5 times, most recently from 6c8ca0e to 0261229 Compare December 3, 2021 21:17
Build containerd/continuity on multiple Unix OSes
e096714 
While the .go files have multiple build tags, they haven't been tested on
GitHub Actions except for FreeBSD.

This change also fixes containerd#183.

Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
@kzys kzys marked this pull request as ready for review December 3, 2021 21:24
@kzys kzys mentioned this pull request Dec 3, 2021
Open
@samuelkarp

samuelkarp commented Dec 6, 2021

Copy link
Copy Markdown
Member

Other than just cross-compiling, have we done any testing on those other operating systems? (In other words: should we include build tags and thus "support" for an operating system that is not tested?)

@kzys

kzys commented Dec 6, 2021

Copy link
Copy Markdown
Member Author

No. We technically could use GitHub Actions' macOS builder to run VirtualBox (like we do in containerd), but I haven't tried that yet.

I still think this is better than what we have today. We have a bunch of build tags but the combinations are not really tested.

@samuelkarp

samuelkarp commented Dec 6, 2021

Copy link
Copy Markdown
Member

I was going to say that it looks like openbsd and netbsd are new additions and maybe we should let compilation fail, but I see in #183 that @AkihiroSuda is trying to use continuity on netbsd already.

Looks like there's already a note in the readme about support, so I think this is fine.

@kzys

kzys commented Dec 16, 2021

Copy link
Copy Markdown
Member Author

@estesp Can you take a look? This should be okay to merge LGTM-wise.

estesp
estesp approved these changes Dec 17, 2021
View reviewed changes

@estesp estesp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@estesp estesp merged commit e56e17d into containerd:main Dec 17, 2021
@dmcgowan dmcgowan mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@samuelkarp samuelkarp samuelkarp approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support GOOS=netbsd

4 participants

@kzys @samuelkarp @dmcgowan @estesp