Move containerd fs package in tree#101
Conversation
|
I have not yet setup the Makefile for root tests ala containerd. |
|
LGTM on first pass. |
|
Ah good, I need to find some time to work on this now... |
This allows the fs package to be versioned separately from containerd and makes for a nice interface for filesystem interactions in continuity. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
de3f617 to
2a3382e
Compare
Signed-off-by: Brian Goff <cpuguy83@gmail.com>
d5ca41c to
65ea282
Compare
|
For some reason we need sudo to run the fs tests. |
|
Ok, this is green. |
|
LGTM, I think we should reorganize README to cover non-proto packages like this |
|
Sudo doesnt affest seccomp policy so no...
…On 25 Jan 2018 00:09, "Brian Goff" ***@***.***> wrote:
For some reason we need sudo to run the fs tests.
copy_file_range is getting EPERM otherwise.... could be related to a
seccomp policy or something in the travis container config?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#101 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAdcPCzNiyUpmB3pSjBzGhSaiPtC9qnoks5tN8Y-gaJpZM4RqmbC>
.
|
|
@justincormack Well, when |
|
Ah. Well almost certainly then they are running a seccomp policy/docker version that is older than their kernel, so doesnt know about |
|
Can you drop the |
This seems to be required for the fs tests. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
b69da81 to
650694e
Compare
|
Good catch, done. |
|
|
||
| // CopyDir copies the directory from src to dst. | ||
| // Most efficient copy of files is attempted. | ||
| func CopyDir(dst, src string) error { |
There was a problem hiding this comment.
Let's save this discussion. We need to do a 3 way merge of this function, with one Tonis wrote, and one in Moby. Yes we should rename it, but we can do that after we move it.
There was a problem hiding this comment.
Let me elaborate a bit more...
- This function only handles doing a direct copy of directories, attempts to use copy file range to speed things up.
- Moby function is also doing a directory copy but other optimizations have been added to make sure the copy is fast and there is a an open PR to speed it up more with parallelizing the slower parts.
- Tonis has a similar copy function he uses for build kit but can also apply filters (and maybe works on more than just directories?).
This allows the fs package to be versioned separately from containerd
and makes for a nice interface for filesystem interactions in
continuity.