Skip to content

.github: windows should use fix critool version#9871

Merged
fuweid merged 1 commit intocontainerd:mainfrom
fuweid:fix-windows-ci-main
Feb 25, 2024
Merged

.github: windows should use fix critool version#9871
fuweid merged 1 commit intocontainerd:mainfrom
fuweid:fix-windows-ci-main

Conversation

@fuweid
Copy link
Copy Markdown
Member

@fuweid fuweid commented Feb 24, 2024 •
edited
Loading

It's trying to fix CI issue #9855

https://github.com/containerd/containerd/actions/runs/8015987871/job/21897145968?pr=9855

NOTE: Maybe we should maintain a script to download critools, like what we do in linux platform. cc @kiashok

@fuweid
.github: windows should use fix critool version
5351ad6 
Signed-off-by: Wei Fu <fuweid89@gmail.com>
@k8s-ci-robot
Copy link
Copy Markdown

k8s-ci-robot commented Feb 24, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@fuweid fuweid marked this pull request as ready for review February 25, 2024 07:34
@fuweid fuweid added ok-to-test cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Feb 25, 2024
@fuweid fuweid added this pull request to the merge queue Feb 25, 2024
Merged via the queue into containerd:main with commit 7f0f49b Feb 25, 2024
@fuweid fuweid deleted the fix-windows-ci-main branch February 26, 2024 02:17
@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Feb 26, 2024

/cherry-pick release/1.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 26, 2024

@fuweid: only containerd org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

Details

In response to this:

/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fuweid
Copy link
Copy Markdown
Member Author

fuweid commented Feb 26, 2024

/cherry-pick release/1.7

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Feb 26, 2024

@fuweid: new pull request created: #9874

Details

In response to this:

/cherry-pick release/1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 26, 2024
Merged
@fuweid fuweid added cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akhilerm akhilerm akhilerm approved these changes

@kiashok kiashok kiashok approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch ok-to-test size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fuweid @k8s-ci-robot @k8s-infra-cherrypick-robot @akhilerm @kiashok