Skip to content

adds mediatype to oci index record#9867

Merged
estesp merged 1 commit intocontainerd:mainfrom
daghack:oci-add-mediatype
Feb 29, 2024
Merged

adds mediatype to oci index record#9867
estesp merged 1 commit intocontainerd:mainfrom
daghack:oci-add-mediatype

Conversation

@daghack
Copy link
Contributor

@daghack daghack commented Feb 23, 2024

While digging into buildkit issue #4595, we noticed that this would also be appropriate to add into containerd to better match spec.

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 23, 2024

Hi @daghack. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

estesp
estesp approved these changes Feb 26, 2024
View reviewed changes
Copy link
Member

@estesp estesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree, I think it makes sense to have the media type here

@dmcgowan dmcgowan added cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Feb 27, 2024
@dmcgowan
Copy link
Member

dmcgowan commented Feb 27, 2024

Thank you for the contribution! Please sign your commit using git commit -s, see https://github.com/containerd/project/blob/main/CONTRIBUTING.md#sign-your-work

@daghack
adds mediatype to oci index record
17ea395 
Signed-off-by: Talon Bowler <talon.bowler@docker.com>
@daghack
Copy link
Contributor Author

daghack commented Feb 29, 2024

Ah, yes! Pardon! Signed now. :)

@estesp estesp added this pull request to the merge queue Feb 29, 2024
mikebrow
mikebrow approved these changes Feb 29, 2024
View reviewed changes
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Merged via the queue into containerd:main with commit 9a2b855 Feb 29, 2024
This was referenced Jul 16, 2024
Merged
Merged
@tianon tianon mentioned this pull request Oct 29, 2024
Merged
@austinvazquez austinvazquez added cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch and removed cherry-pick/1.6.x cherry-pick/1.7.x Change to be cherry picked to release/1.7 branch labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmcgowan dmcgowan dmcgowan approved these changes

@estesp estesp estesp approved these changes

@mikebrow mikebrow mikebrow approved these changes

Assignees

No one assigned

Labels

cherry-picked/1.6.x PR commits are cherry-picked into release/1.6 branch cherry-picked/1.7.x PR commits are cherry-picked into release/1.7 branch size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@daghack @k8s-ci-robot @dmcgowan @estesp @mikebrow @austinvazquez