Skip to content

Extract setup-go step into composite action#9786

Merged
mxpv merged 3 commits intocontainerd:mainfrom
mxpv:ci
Feb 9, 2024
Merged

Extract setup-go step into composite action#9786
mxpv merged 3 commits intocontainerd:mainfrom
mxpv:ci

Conversation

@mxpv
Copy link
Copy Markdown
Member

@mxpv mxpv commented Feb 7, 2024

This PR moves setup-go step into a separate composite action that can be called from other workflows. This significantly reduced the number of places where we need to change go versions.

mxpv added 2 commits February 7, 2024 12:28
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
Signed-off-by: Maksym Pavlenko <pavlenko.maksym@gmail.com>
@austinvazquez
Copy link
Copy Markdown
Member

Would it be good to update release workflow as well?

@mxpv
Copy link
Copy Markdown
Member Author

mxpv commented Feb 8, 2024

Would it be good to update release workflow as well?

@austinvazquez release workflow doesn't use actions/setup-go@v5, this requires different refactoring (that @akhilerm mentioned in the comment)

Copy link
Copy Markdown
Member

@akhilerm akhilerm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@austinvazquez
Copy link
Copy Markdown
Member

Would it be good to update release workflow as well?

@austinvazquez release workflow doesn't use actions/setup-go@v5, this requires different refactoring (that @akhilerm mentioned in the comment)

Ah I understand now. Thanks.

@mxpv mxpv added this pull request to the merge queue Feb 9, 2024
Merged via the queue into containerd:main with commit b3f1c15 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants