Skip to content

[release/1.7] bug fix: make sure cri image is pinned when it is pulled outside cri#9784

Merged
estesp merged 1 commit intocontainerd:release/1.7from
henry118:release/1.7
Feb 9, 2024
Merged

[release/1.7] bug fix: make sure cri image is pinned when it is pulled outside cri#9784
estesp merged 1 commit intocontainerd:release/1.7from
henry118:release/1.7

Conversation

@henry118
Copy link
Copy Markdown
Member

@henry118 henry118 commented Feb 7, 2024

Cherry-pick: #9732

Signed-off-by: Henry Wang henwang@amazon.com
(cherry picked from commit 1eaf0c1)

@estesp
Copy link
Copy Markdown
Member

estesp commented Feb 7, 2024

=== RUN   TestContainerdSandboxImagePulledOutsideCRI
    containerd_image_test.go:244: make sure the pause image does not exist
    containerd_image_test.go:247: pull pause image
    containerd_image_test.go:251: pause image should be seen by cri plugin
    containerd_image_test.go:258: verify pinned field is set for pause image
    containerd_image_test.go:259: 
        	Error Trace:	/home/runner/work/containerd/containerd/integration/containerd_image_test.go:259
        	Error:      	Should be true
        	Test:       	TestContainerdSandboxImagePulledOutsideCRI
    containerd_image_test.go:261: make sure the pause image exist
    containerd_image_test.go:265: ensure correct labels are set on pause image
    containerd_image_test.go:266: 
        	Error Trace:	/home/runner/work/containerd/containerd/integration/containerd_image_test.go:266
        	Error:      	Not equal: 
        	            	expected: "pinned"
        	            	actual  : ""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-pinned
        	            	+
        	Test:       	TestContainerdSandboxImagePulledOutsideCRI
--- FAIL: TestContainerdSandboxImagePulledOutsideCRI (1.55s)

Signed-off-by: Henry Wang <henwang@amazon.com>
(cherry picked from commit 1eaf0c1)
@estesp estesp merged commit 8e86a0b into containerd:release/1.7 Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants