Skip to content

Update gce configure.sh to use registry config_path #9778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mxpv merged 1 commit into from
Feb 12, 2024
Merged

Update gce configure.sh to use registry config_path #9778

mxpv merged 1 commit into from
Feb 12, 2024

Conversation

@adisky
Copy link
Contributor

@adisky adisky commented Feb 7, 2024 •
edited
Loading

Update gce configure.sh to use registry config_path instead of deprecated registry mirrors

@k8s-ci-robot
Copy link

k8s-ci-robot commented Feb 7, 2024

Hi @adisky. Thanks for your PR.

I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

AkihiroSuda
AkihiroSuda reviewed Feb 7, 2024
View reviewed changes
dmcgowan
dmcgowan reviewed Feb 7, 2024
View reviewed changes
@AkihiroSuda AkihiroSuda mentioned this pull request Feb 7, 2024
Closed
2 tasks
dmcgowan
dmcgowan reviewed Feb 7, 2024
View reviewed changes
@akhilerm
Copy link
Member

akhilerm commented Feb 7, 2024

/ok-to-test

@adisky adisky force-pushed the use-latest-registry-conf branch 3 times, most recently from d048416 to 14c9d7b Compare February 7, 2024 08:31
@adisky
Copy link
Contributor Author

adisky commented Feb 8, 2024

@dmcgowan @AkihiroSuda adressed review comments, pull-containerd-node-e2e is also passing now

cc @mikebrow @dims

dims
dims reviewed Feb 8, 2024
View reviewed changes
@adisky
Update gce configure.sh to use registry config_path
d9b95ab 
Signed-off-by: Aditi Sharma <adi.sky17@gmail.com>
@adisky adisky force-pushed the use-latest-registry-conf branch from 14c9d7b to d9b95ab Compare February 8, 2024 03:57
AkihiroSuda
AkihiroSuda approved these changes Feb 12, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda requested review from dims and dmcgowan February 12, 2024 15:52
@mxpv mxpv added this pull request to the merge queue Feb 12, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 12, 2024
@mxpv mxpv added this pull request to the merge queue Feb 12, 2024
Merged via the queue into containerd:main with commit 4f76ebc Feb 12, 2024
@mikebrow
Copy link
Member

mikebrow commented Feb 15, 2024

thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mxpv mxpv mxpv approved these changes

@estesp estesp estesp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@dims dims Awaiting requested review from dims

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees

No one assigned

Labels

ok-to-test size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@adisky @k8s-ci-robot @akhilerm @mikebrow @dims @dmcgowan @mxpv @estesp @AkihiroSuda