-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Revert "cri: make read-only mounts recursively read-only" #9747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Revert PR 9713, as it appeared to break the compatibility too much kubernetes/enhancements#3858 (comment) This reverts commit b2f254f. > Conflicts: > internal/cri/opts/spec_linux_opts.go Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
94899cb to
6670695
Compare
|
I'm asking that we have the discussion about how to handle these sorts of cases. |
I have spent almost a year to get kubernetes/enhancements#3857 approved
Now I have learnt that this was not enough, and realized a necessity to have some explicit guideline on merging potential breaking changes: |
|
Yep. I am not trying to blame you. We have a KEP that did not get the appropriate attention. We have over-burdened SIGs and maintainers. We have multiple projects with their own policies and stances on what constitutes acceptance risk. Worst, we have a clear lack of data, which makes it impossible to move forward with any real confidence, so we defaulted to the safe position. This is not a healthy place to be. Now what to do with it? I think almost everyone will agree that RRO is a better default. But changing it in the kubernetes-specific corner of containers is not the right fix. |
So, this PR reverts: I'll wait again to see if there is any chance to get the KEP approved. |
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM .. thx
getting harder to keep track .. made harder for us given we have to support N-different k8s releases and we've had containerd 2.0 working in main over 4-5 releases of k8s
Revert PR #9713, as it appeared to break the compatibility too much kubernetes/enhancements#3858 (comment)
This reverts commit b2f254f.